1008 laser digital only modulation doesnt work #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting. Can specify a base class as the return object to provide access to methods and documentation...
Only significant change is in RemoteFocusEquipmentSolutions: num_waiting = self.serial.in_waiting Was inWaiting() Need to confirm that this is not a problem...
Learning the hardway...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1011 +/- ##
===========================================
+ Coverage 53.77% 53.87% +0.09%
===========================================
Files 178 178
Lines 20080 20168 +88
===========================================
+ Hits 10799 10866 +67
- Misses 9281 9302 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| """ | ||
| for i in range(100): | ||
| num_waiting = self.serial.inWaiting() | ||
| num_waiting = self.serial.in_waiting |
There was a problem hiding this comment.
This is the most important thing to test...
|
Thanks @JinlongL for testing the PR |
|
[like] Jinlong Lin reacted to your message:
…________________________________
From: Kevin M. Dean ***@***.***>
Sent: Tuesday, October 8, 2024 9:43:45 PM
To: TheDeanLab/navigate ***@***.***>
Cc: Jinlong Lin ***@***.***>; Mention ***@***.***>
Subject: Re: [TheDeanLab/navigate] 1008 laser digital only modulation doesnt work (PR #1011)
EXTERNAL MAIL
Thanks @JinlongL<https://urldefense.com/v3/__https://github.com/JinlongL__;!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qfIeD9dzg$> for testing the PR
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/TheDeanLab/navigate/pull/1011*issuecomment-2400875224__;Iw!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qf8FLnGwc$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AW5R4SG2E5B2G64BJN7TMTLZ2RGZDAVCNFSM6AAAAABPSG6WZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQHA3TKMRSGQ__;!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qfqHC80O0$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
CAUTION: This email originated from outside UTSW. Please be cautious of links or attachments, and validate the sender's email address before replying.
________________________________
UT Southwestern
Medical Center
The future of medicine, today.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up being more of an exploration on type hinting to make debugging in an IDE easier. Will circle back to #1008