Skip to content

Conversation

annie-xd-wang
Copy link
Collaborator

No description provided.

@annie-xd-wang
Copy link
Collaborator Author

We can start testing with the feature pipeline: [{"name": ZStackAcquisition,"args": (False,False,"z-stack",True,),},{"name": WaitToContinue,},{"name": VolumeSearch3D,"args": ("Nanoscale","N/A",0,1,0.5,None,),},{"name": WaitToContinue,},{"name": ChangeResolution,"args": ("Nanoscale","N/A",),},{"name": ZStackAcquisition,"args": (False,False,"z-stack",True,),},]. We need to load a custom function to accurately label the images for improved results.

@annie-xd-wang annie-xd-wang marked this pull request as ready for review November 12, 2024 22:14
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 28.31169% with 276 lines in your changes missing coverage. Please review.

Project coverage is 53.98%. Comparing base (b7412e9) to head (81c5064).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/features/update_setting.py 15.53% 87 Missing ⚠️
src/navigate/model/features/volume_search.py 8.57% 64 Missing ⚠️
src/navigate/model/analysis/boundary_detect.py 8.92% 51 Missing ⚠️
...rc/navigate/model/data_sources/tiff_data_source.py 30.76% 36 Missing ⚠️
src/navigate/model/features/image_writer.py 68.96% 18 Missing ⚠️
...igate/controller/sub_controllers/features_popup.py 8.33% 11 Missing ⚠️
src/navigate/model/data_sources/data_source.py 69.23% 4 Missing ⚠️
src/navigate/controller/controller.py 57.14% 3 Missing ⚠️
src/navigate/model/features/common_features.py 50.00% 1 Missing ⚠️
src/navigate/model/model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1013      +/-   ##
===========================================
- Coverage    54.32%   53.98%   -0.34%     
===========================================
  Files          180      181       +1     
  Lines        20428    20697     +269     
===========================================
+ Hits         11097    11174      +77     
- Misses        9331     9523     +192     
Flag Coverage Δ
unittests 53.98% <28.31%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW
Copy link
Collaborator

Is this ready for review @annie-xd-wang ?

@annie-xd-wang
Copy link
Collaborator Author

Yes, it is ready for review.

Image data
"""
# TODO: may need to support .tif
file_suffix = ".ome.tiff" if self.is_ome else ".tiff"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use a try/except/finally statement to also support ".tif"?

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit b7504bf into TheDeanLab:develop Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants