-
Notifications
You must be signed in to change notification settings - Fork 12
3 d volume search #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 d volume search #1013
Conversation
The feature has been added to a pipeline for tests. The structure works. Need to map the boundaries to positions.
We can start testing with the feature pipeline: [{"name": ZStackAcquisition,"args": (False,False,"z-stack",True,),},{"name": WaitToContinue,},{"name": VolumeSearch3D,"args": ("Nanoscale","N/A",0,1,0.5,None,),},{"name": WaitToContinue,},{"name": ChangeResolution,"args": ("Nanoscale","N/A",),},{"name": ZStackAcquisition,"args": (False,False,"z-stack",True,),},]. We need to load a custom function to accurately label the images for improved results. |
This reverts commit 134b201.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1013 +/- ##
===========================================
- Coverage 54.32% 53.98% -0.34%
===========================================
Files 180 181 +1
Lines 20428 20697 +269
===========================================
+ Hits 11097 11174 +77
- Misses 9331 9523 +192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is this ready for review @annie-xd-wang ? |
Yes, it is ready for review. |
Image data | ||
""" | ||
# TODO: may need to support .tif | ||
file_suffix = ".ome.tiff" if self.is_ome else ".tiff" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use a try/except/finally statement to also support ".tif"?
No description provided.