Skip to content

Conversation

juhelh
Copy link
Contributor

@juhelh juhelh commented Aug 6, 2025

This PR updates the XCaliburPump implementation to make it compatible with the Navigate device layer and naming conventions.


Changes based on integration feedback

  • File naming: Renamed to tecan.py to match manufacturer name.
  • Class naming: Renamed to XCaliburPump to match device model.
  • Constructor updated: Now follows the standard device interface.
  • Connection interface: Added required @classmethod connect(...) for serial devices.
  • Error handling: Replaced RuntimeError, ValueError, etc., with UserVisibleException.

Tests

  • Test suite updated to match refactored interface.
  • Uses pytest and mocks Serial with a custom FakeSerial class.

Notes

@AdvancedImagingUTSW AdvancedImagingUTSW self-requested a review August 6, 2025 16:44
…-compatible attribute descriptions. Add __init__.py to device folder.
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 68009cd into TheDeanLab:develop Aug 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants