Tai's branch #1124
Merged
Tai's branch #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He needs to make his own branch.
Updated ConfigurationController to handle all stage axes dynamically instead of a fixed set. Returned stage speed settings to 90% in ASI and MS2000 stage classes. WIll add to the advanced stage popup in next commit.
Introduces home position fields and update buttons to the advanced stage parameters popup, updates controller logic to handle home positions, and adjusts layout to accommodate new controls. @annie-xd-wang - I may need your help coming up with a proper solution. Right now, when we query the stages, it only does it for the active microscope, and it will only return the stage positions for the standard x, y, z, f, theta stages. A better solution would be to know which microscope is what, and the query the stage there.
Introduces a new 'query_select_microscope' command to Controller and Model, allowing thread-blocking queries for a specific microscope's stage positions. AdvancedStageParametersController now uses this to update axis limits based on the selected microscope, allowing one to query non-standard stages.
Replaces grid-based column headers with ttk.LabelFrames for each functional area, improving visual grouping and alignment. Widgets for each stage are now placed inside their respective column frames, and row heights are normalized for perfect alignment. Updates widget clearing logic to handle new column frames and row widgets. Also, to make it easier to find the updated values in the yaml file, this is now sorted alphabetically.
|
@annie-xd-wang - This should hopefully be ready to review. While reviewing @tngo2019's code, I realized that the advanced stage settings popup would struggle with non-default stages, so I had to add logic to query a specific stage from a specific microscope instance. In the process, made the popup a bit cleaner by organizing each update category within a common label frame. Hopefully the tests pass. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1124 +/- ##
===========================================
- Coverage 54.00% 53.87% -0.13%
===========================================
Files 191 191
Lines 21785 21893 +108
===========================================
+ Hits 11765 11795 +30
- Misses 10020 10098 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annie-xd-wang
approved these changes
Aug 12, 2025
AdvancedImagingUTSW
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
He needs to make his own branch.