Update shear parameters #1136
Merged
Update shear parameters #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix affine shear transform calculation in linear_algebra.py Now, also correct pixel size to account for shearing-based acquisition. The shear data button must be selected for this to currently be active.
Moved pixel size scaling for shear transforms earlier in the process and removed debug print statements. Added calculation and application of shear offset transforms in view registrations. Added placeholders for future implementation of XZ and other shear dimensions.
Fixed the affine shear transformation to tile in Z and tested and it worked
Refined widget state handling in AcquireBarController to differentiate between 'dimension' and other widgets, setting their states appropriately. Removed debug print statements.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1136 +/- ##
===========================================
- Coverage 53.72% 53.57% -0.16%
===========================================
Files 194 194
Lines 22337 22358 +21
===========================================
- Hits 12001 11978 -23
- Misses 10336 10380 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdvancedImagingUTSW
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested new affine shear and tiling, it worked as intended.