Skip to content

Conversation

TrungNguyenDuc
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two new Newport stage controllers: the Newport ESP302 multi-axis stage (newport.py) and the Newport CONEX-CC single-axis stage (conex.py). Both implementations follow the existing stage device architecture and provide telnet/serial communication interfaces respectively.

Key changes:

  • Implementation of Newport ESP302 stage with telnet communication for multi-axis control
  • Implementation of Newport CONEX-CC stage with serial communication for single-axis control
  • Registration of both devices in the configuration database

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/navigate/model/devices/stage/newport.py Complete implementation of Newport ESP302 multi-axis stage with telnet communication
src/navigate/model/devices/stage/conex.py Complete implementation of Newport CONEX-CC single-axis stage with serial communication
src/navigate/config/configuration_database.py Registration of both Newport devices in the stage device mapping
Comments suppressed due to low confidence (1)

src/navigate/model/devices/stage/newport.py:1

  • String matching on exception text is fragile. Consider catching PermissionError specifically or checking the exception type instead of string content.
# Copyright (c) 2021-2024 The University of Texas Southwestern Medical Center.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Quickly confirmed that the documentation is correct. Linted and formatted code. Updated license.
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit e4275ac into TheDeanLab:develop Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants