Skip to content

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

On John's system, there are other types of cards that are not included with our other Tiger Controller builds. This includes piezos, for example, which do not recognize some of the commands we use to set the speed as a percent of the max speed. This fix now goes through all of the stages and removes those that do not qualify.

https://www.asiimaging.com/docs/products/serial_commands#commandbuild_bu

On John's system, there are other types of cards that are not included with our other Tiger Controller builds. This includes piezos, for example, which do not recognize some of the commands we use to set the speed as a percent of the max speed. This fix now goes through all of the stages and removes those that do not qualify.

https://www.asiimaging.com/docs/products/serial_commands#commandbuild_bu
@AdvancedImagingUTSW
Copy link
Collaborator Author

We should test this on the BT-MesoSPIM before proceeding with the merge...

@AdvancedImagingUTSW
Copy link
Collaborator Author

Confirmed to work on BT-MesoSPIM.

Path get_default_motor_axis_sequence in unit tests to pass the tests.
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.82%. Comparing base (9f58606) to head (6f3f279).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...ate/model/devices/APIs/asi/asi_tiger_controller.py 14.28% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #993      +/-   ##
===========================================
- Coverage    53.89%   53.82%   -0.07%     
===========================================
  Files          178      178              
  Lines        19585    19593       +8     
===========================================
- Hits         10555    10546       -9     
- Misses        9030     9047      +17     
Flag Coverage Δ
unittests 53.82% <14.28%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 593acb5 into develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants