Skip to content

Conversation

AdvancedImagingUTSW
Copy link
Collaborator

No description provided.

@AdvancedImagingUTSW
Copy link
Collaborator Author

Updating the license on all of the files triggered the pre-commit, which is why there are a lot of minor tweaks to whitespace, etc.

I am carefully looking over each of the changes. Will test on a few microscopes and proceed with the merge if everything looks okay.

Fix tests, make sure that __repr__ is not in the base classes.
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 37.72242% with 175 lines in your changes missing coverage. Please review.

Project coverage is 53.54%. Comparing base (578989d) to head (daee1dc).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...te/model/devices/APIs/asi/asi_MS2000_controller.py 0.00% 17 Missing ⚠️
.../model/devices/remote_focus/equipment_solutions.py 0.00% 12 Missing ⚠️
src/navigate/model/devices/camera/hamamatsu.py 0.00% 10 Missing ⚠️
...vigate/model/data_sources/pyramidal_data_source.py 30.76% 9 Missing ⚠️
src/navigate/model/device_startup_functions.py 11.11% 8 Missing ⚠️
src/navigate/model/devices/filter_wheel/ludl.py 0.00% 7 Missing ⚠️
src/navigate/model/devices/filter_wheel/ni.py 0.00% 7 Missing ⚠️
src/navigate/model/devices/stages/sutter.py 0.00% 7 Missing ⚠️
...igate/model/devices/APIs/asi/asi_MFC_controller.py 0.00% 6 Missing ⚠️
src/navigate/model/devices/APIs/sutter/MP285.py 33.33% 6 Missing ⚠️
... and 44 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #996      +/-   ##
===========================================
- Coverage    53.61%   53.54%   -0.07%     
===========================================
  Files          178      178              
  Lines        19798    19959     +161     
===========================================
+ Hits         10614    10688      +74     
- Misses        9184     9271      +87     
Flag Coverage Δ
unittests 53.54% <37.72%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 9120c03 into develop Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants