Skip to content

Conversation

@manasmithamn
Copy link
Contributor

@manasmithamn manasmithamn commented Oct 19, 2025

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

Copy link
Contributor Author

@manasmithamn manasmithamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo and file name fixed

Fixed numeric conversion of command line params
removed empty line at the end
Copy link
Contributor Author

@manasmithamn manasmithamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed empty line at the end

fixed typo in line 8, cmd line param numeric conversion
fixed the program, I was either dozing or hallucinating .. I was typing fibonacci check code under remove all white space, need to get good sleep after 6 commits
Copy link
Contributor Author

@manasmithamn manasmithamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the program, I was either dozing or hallucinating .. I was typing fibonacci check code under remove all white space, need to get good sleep after 6 commits

@rzuckerm rzuckerm changed the title Create remove-all-white-space.r Add Remove All Whitespace in R Oct 19, 2025
@rzuckerm
Copy link
Collaborator

rzuckerm commented Oct 19, 2025

Please take some time to read the Contributing Guide. Also, there is a test failure. Please take a look at the workflow run.

@rzuckerm rzuckerm added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related remove all whitespace See: https://sampleprograms.io/projects/remove-all-whitespace/ labels Oct 19, 2025
# Remove all white spaces
args <- commandArgs(trailingOnly = TRUE)

if (length(args) == 0 || args[1] == "" || is.null(args[1]) ){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for is.null is redundant, since length(args) == 0 checks that case already.

args <- commandArgs(trailingOnly = TRUE)

if (length(args) == 0 || args[1] == "" || is.null(args[1]) ){
cat("Usage: please provide a string")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should have a newline attached to it since cat doesn't add a line feed by default, and also quit(status = 1) after that to make sure it exits the program.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I withdraw this request Sir.

I am not able to do this with R Code.

@rzuckerm rzuckerm closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo hacktoberfest Hacktoberfest related remove all whitespace See: https://sampleprograms.io/projects/remove-all-whitespace/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Remove All Whitespace in R

3 participants