- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 624
Add Remove All Whitespace in R #5130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
file extension fixed from .r to .R
typo and file name fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo and file name fixed
Fixed numeric conversion of command line params
removed empty line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed empty line at the end
fixed typo in line 8, cmd line param numeric conversion
fixed the program, I was either dozing or hallucinating .. I was typing fibonacci check code under remove all white space, need to get good sleep after 6 commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the program, I was either dozing or hallucinating .. I was typing fibonacci check code under remove all white space, need to get good sleep after 6 commits
| Please take some time to read the Contributing Guide. Also, there is a test failure. Please take a look at the workflow run. | 
| # Remove all white spaces | ||
| args <- commandArgs(trailingOnly = TRUE) | ||
|  | ||
| if (length(args) == 0 || args[1] == "" || is.null(args[1]) ){ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking for is.null is redundant, since length(args) == 0 checks that case already.
| args <- commandArgs(trailingOnly = TRUE) | ||
|  | ||
| if (length(args) == 0 || args[1] == "" || is.null(args[1]) ){ | ||
| cat("Usage: please provide a string") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should have a newline attached to it since cat doesn't add a line feed by default, and also quit(status = 1) after that to make sure it exits the program.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I withdraw this request Sir.
I am not able to do this with R Code.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Adding a New Code Snippet in an Existing Language
Add {PROJECT} in {LANGUAGE}format