Skip to content

bugfix: Chinooks and Helixes no longer take off after repair if passengers want to board or exit #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: Chinooks and Helixes no longer take off after repair if passengers want to board or exit #1787

wants to merge 1 commit into from
+12 −4

Conversation

@Stubbjax
Copy link

@Stubbjax Stubbjax commented Nov 3, 2025 •
edited
Loading

This change prevents repairing Chinooks and Helixes from taking off after repairing completes when there are passengers waiting to board or exit.

Before

The Chinook takes off after healing completes even though passengers intend to board

IGNORE_PASSENGERS.mp4

After

The Chinook stays landed after healing completes as passengers intend to board

AWAIT_PASSENGERS.mp4

@Stubbjax Stubbjax self-assigned this Nov 3, 2025
@Stubbjax Stubbjax added AI Is AI related Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour NoRetail This fix or change is not applicable with Retail game compatibility labels Nov 3, 2025
@Skyaero42
Copy link

Skyaero42 commented Nov 3, 2025

What is the difference between this en #1762?

@Stubbjax
Copy link
Author

Stubbjax commented Nov 3, 2025

What is the difference between this en #1762?

There are two separate cases in the retail game when a repairing Chinook or Helix will lift off:

1: Repairing has finished → lift off even if passengers intend to exit or board (fixed by #1787)
2: Passengers have evacuated → lift off even if healing is not finished (fixed by #1762)

@Skyaero42 Skyaero42 added Fix Is fixing something, but is not user facing and removed Bug Something is not working right, typically is user facing labels Nov 3, 2025
Skyaero42
Skyaero42 approved these changes Nov 3, 2025
View reviewed changes
Copy link

@Skyaero42 Skyaero42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

  • Tested and works as described.
  • Tested that the RETAIL_COMPATIBLE_CRC guard is used correctly. Normal build does not mismatch against retail.
  • Also verified it works for Helix.
  • The code looks good.

@Skyaero42 Skyaero42 added the Approved Pull Request was approved label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skyaero42 Skyaero42 Skyaero42 approved these changes

Assignees

@Stubbjax Stubbjax

Labels

AI Is AI related Approved Pull Request was approved Fix Is fixing something, but is not user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker NoRetail This fix or change is not applicable with Retail game compatibility ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stubbjax @Skyaero42