build: Move refcount.h include into WWCommon.h #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
This reverts commit 03a51c2.
Author
|
Fought through various VC6 compile errors. Should be ok now. |
bobtista
reviewed
Nov 5, 2025
|
LGTM. Should we add another PR to convert all NULLs to nullptr? There's like 1700 of them in WW3D2. and like 40,000 of them in the whole codebase |
Author
Yes. There is a clang tidy feature for that: We would first need to get the clang tidy setup. There was such an attempt here: #1580 |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the refcount.h include into WWCommon.h
It is now always available across Engine and WWVegas and some of the tools.