Skip to content

Listen on localhost instead of all available IPs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlusiardi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Listen on localhost instead of all available IPs #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5371fb2
Bind to localhost instead of all
jlusiardi Jun 23, 2018
3797f5a
Change default listen address to localhost
jlusiardi Jun 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/brickd/config_options.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static const char *config_format_red_led_trigger(int value) {
#endif

ConfigOption config_options[] = {
CONFIG_OPTION_STRING_INITIALIZER("listen.address", 1, -1, "0.0.0.0"),
CONFIG_OPTION_STRING_INITIALIZER("listen.address", 1, -1, "127.0.0.1"),
CONFIG_OPTION_INTEGER_INITIALIZER("listen.plain_port", 1, UINT16_MAX, 4223),
CONFIG_OPTION_INTEGER_INITIALIZER("listen.websocket_port", 0, UINT16_MAX, 0), // default to enable: 4280
CONFIG_OPTION_INTEGER_INITIALIZER("listen.mesh_gateway_port", 1, UINT16_MAX, 4240),
Expand Down
4 changes: 2 additions & 2 deletions src/build_data/linux/installer/etc/brickd-default.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
# Bricks and Bricklets connected to it. We strongly recommend that you enable
# authentication if you enabled WebSocket support.
#
# The default values are 0.0.0.0, 4223, 0 (disabled), 4240 and off.
listen.address = 0.0.0.0
# The default values are 127.0.0.1, 4223, 0 (disabled), 4240 and off.
listen.address = 127.0.0.1
listen.plain_port = 4223
listen.websocket_port = 0
listen.mesh_gateway_port = 4240
Expand Down
4 changes: 2 additions & 2 deletions src/build_data/linux/installer/etc/brickd-red-brick.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
# Bricks and Bricklets connected to it. We strongly recommend that you enable
# authentication if you enabled WebSocket support.
#
# The default values are 0.0.0.0, 4223, 0 (disabled), 4240 and off.
listen.address = 0.0.0.0
# The default values are 127.0.0.1, 4223, 0 (disabled), 4240 and off.
listen.address = 127.0.0.1
listen.plain_port = 4223
listen.websocket_port = 0
listen.mesh_gateway_port = 4240
Expand Down
2 changes: 1 addition & 1 deletion src/build_data/linux/installer/usr/share/man/man5/brickd.conf.5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ connections.
binds a plain TCP/IP socket and a WebSocket to this address to listen for
incoming plain TCP/IP and WebSocket connections. The address can either be a
dotted-decimal IPv4 address or a hexadecimal IPv6 address. It can also be a
hostname such as \fIlocalhost\fR. The default value is \fI0.0.0.0\fR.
hostname such as \fIlocalhost\fR. The default value is \fI127.0.0.1\fR.
.IP "\fBlisten.plain_port\fR" 4
The port number to listen to for incoming plain TCP/IP connections. The default
value is \fI4223\fR.
Expand Down
2 changes: 1 addition & 1 deletion src/build_data/linux/installer/usr/share/man/man8/brickd.8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ available for various programming languages.
Bricks connected to USB are identified using their vendor ID (16D0) and product
IDs (063D and 09E5).
.PP
By default, brickd binds to 0.0.0.0 (IPv4) and listens on port 4223 for
By default, brickd binds to 127.0.0.1 (IPv4) and listens on port 4223 for
incoming TCP/IP connections. Listening for incoming WebSocket connections is
disabled by default for security reasons. The bind address (IPv4 or IPv6),
listen ports, dual-stack operation and WebSocket support can be configured in
Expand Down
4 changes: 2 additions & 2 deletions src/build_data/macos/installer/root/etc/brickd.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
# Bricks and Bricklets connected to it. We strongly recommend that you enable
# authentication if you enabled WebSocket support.
#
# The default values are 0.0.0.0, 4223, 0 (disabled), 4240 and off.
listen.address = 0.0.0.0
# The default values are 127.0.0.1, 4223, 0 (disabled), 4240 and off.
listen.address = 127.0.0.1
listen.plain_port = 4223
listen.websocket_port = 0
listen.mesh_gateway_port = 4240
Expand Down
4 changes: 2 additions & 2 deletions src/build_data/windows/brickd.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
# Bricks and Bricklets connected to it. We strongly recommend that you enable
# authentication if you enabled WebSocket support.
#
# The default values are 0.0.0.0, 4223, 0 (disabled), 4240 and off.
listen.address = 0.0.0.0
# The default values are 127.0.0.1, 4223, 0 (disabled), 4240 and off.
listen.address = 127.0.0.1
listen.plain_port = 4223
listen.websocket_port = 0
listen.mesh_gateway_port = 4240
Expand Down