Skip to content

Conversation

benfdking
Copy link
Contributor

@benfdking benfdking commented Jul 31, 2025

  • Sets a setup for vscode to be passed multiple project paths
  • Passes those to the lsp on initialization
  • Adds a test to test this

@benfdking benfdking force-pushed the multi_repo_for_vscode branch from 50a105a to 2fe5f5c Compare July 31, 2025 16:47
@benfdking benfdking marked this pull request as draft July 31, 2025 16:47
@benfdking benfdking force-pushed the multi_repo_for_vscode branch 2 times, most recently from 26a7253 to c65470b Compare August 13, 2025 14:56
@benfdking benfdking marked this pull request as ready for review August 13, 2025 14:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements multi-project support for the VSCode SQLMesh extension by allowing users to configure multiple project paths instead of a single project path. The extension now passes these paths to the Language Server Protocol (LSP) during initialization, enabling the LSP to handle multiple SQLMesh projects simultaneously.

Key changes:

  • Updated configuration from sqlmesh.projectPath (string) to sqlmesh.projectPaths (array)
  • Modified LSP initialization to pass project paths as initialization options
  • Added support for multi-project handling in the SQLMesh Language Server

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vscode/extension/package.json Updates configuration schema to accept array of project paths
vscode/extension/src/utilities/config.ts Refactors configuration handling to support multiple project paths
vscode/extension/src/lsp/lsp.ts Passes resolved project paths to LSP during initialization
vscode/extension/src/utilities/sqlmesh/sqlmesh.ts Updates function calls to use new resolved path structure
sqlmesh/lsp/main.py Adds support for receiving and handling multiple project paths
vscode/extension/tests/utils.ts Adds test utility for multi-project example path
vscode/extension/tests/multi_project.spec.ts Adds test case for multi-project functionality
vscode/extension/tests/lineage.spec.ts Updates existing tests to use new array-based configuration
examples/multi/.vscode/settings.json Provides example configuration for multi-project setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@benfdking benfdking force-pushed the multi_repo_for_vscode branch from 9181010 to c65470b Compare August 14, 2025 12:14
Copy link
Contributor

@themisvaltinos themisvaltinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe have a small section in vscode.md that explains that the project paths need to be added in the settings to enable this

@benfdking benfdking force-pushed the multi_repo_for_vscode branch from c65470b to 458a858 Compare August 15, 2025 09:02
@benfdking benfdking enabled auto-merge (squash) August 15, 2025 09:17
@benfdking benfdking merged commit 527e107 into main Aug 15, 2025
26 of 28 checks passed
@benfdking benfdking deleted the multi_repo_for_vscode branch August 15, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants