fix note title color for legacy themes

[Nriver]

fix second part of #7984

[gemini-code-assist]

Summary of Changes

Hello @Nriver, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual inconsistency where the active note title within the Fancytree component did not properly display the custom theme color in legacy dark and light themes. The changes introduce specific CSS rules to apply the appropriate custom color variable to the active Fancytree span element, thereby resolving the display bug and enhancing the visual coherence of the user interface.

Highlights

• Note Title Coloring: Ensures that the active note title in the Fancytree component correctly uses the custom theme color for both dark and light legacy themes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue where the custom color of a note title is lost when the note becomes active in the tree view for legacy themes. While the proposed changes in theme-dark.css and theme-light.css address this for colored notes, they introduce a side effect for non-colored notes. Specifically, in the dark theme, it causes an accessibility issue due to low text-to-background contrast for active items. My review includes suggestions to refine the CSS rules to correctly apply colors only to the intended notes by using the existing --custom-color variable with a fallback, thus resolving the original issue without introducing new problems.

[gemini-code-assist]

This rule correctly fixes the issue for colored notes, but it also affects non-colored active notes. For non-colored notes, the color will fall back to an inherited color (likely --left-pane-text-color: #aaaaaa), which has a very low contrast ratio (1.77:1) with the active background (--active-item-background-color: #777), causing an accessibility issue.

To address this, I suggest using the --custom-color variable, which is set for colored notes, and providing a fallback to the original --active-item-text-color. This ensures that colored notes keep their color when active, while non-colored notes retain their high-contrast active color.

Suggested change

	span.fancytree-active {
	color: var(--dark-theme-custom-color);
	}
	span.fancytree-active {
	color: var(--custom-color, var(--active-item-text-color));
	}

[gemini-code-assist]

For consistency with the fix in theme-dark.css and to make the implementation more robust, I suggest a similar change here. While the contrast issue is not present in the light theme, using --custom-color with a fallback to --active-item-text-color correctly applies the color only to notes that are meant to be colored, without affecting others. This approach is more aligned with the existing CSS variable architecture and prevents potential side effects.

Suggested change

	span.fancytree-active {
	color: var(--light-theme-custom-color);
	}
	span.fancytree-active {
	color: var(--custom-color, var(--active-item-text-color));
	}