docker-machine-driver-triton#13 Made machine driver compatible with Rancher #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pass in the private SSH key as a base64 encoded string
bahamat
changed the title
bahamat
reviewed
Jun 10, 2022
bahamat
left a comment
bahamat
left a comment
There was a problem hiding this comment.
This looks good, but I'd like to see some test output in both rancher and non-rancher configurations, just to make sure we aren't breaking any existing users.
Author
Sound good, I should be able to get to that in the next few days. |
Author
|
@bahamat Here is the rancher log snippet from creating a new Triton node via the Rancher UI: and here is what I saw in the process tree: The VM was successfully created by Rancher: |
Author
|
Here is the output from using But it appears to have succeeded despite the error in the output: The only difference is that in Rancher |
Author
|
I checked the docker machine source code and it runs And then it does a regex match against the output for the docker port which doesn't find a match because by default the docker daemon only listens on a unix socket and not on tcp: So that explains why it thinks Docker isn't running but it is. I'm just not sure how the rancher machine version gets around this because looking at the source code it appears to do the same thing but it must handle it differently/correctly. |
Author
|
Looks like this is an issue that was never closed in the docker machine repo: The docker service invocations has Anyway, @bahamat my changes in this pull request don't seem to have any negative impact as far as I can tell. |
Author
|
I ran the same test with the driver from the master branch and the same issue occurs which confirms that my changes didn't introduce this issue: This also confirms that my changes don't break the existing functionality when used without the new |
…ion not to validate the CloudAPI SSL certificate in development setups.
Specifying a single tag is functionally the same as node-triton's `-t` argument, Multiple tags can be specified in a comma-delimited format, such as `<tag1>=<value1>,<tag2>=<value2>`.
This was
linked to
issues
Feb 1, 2024
Modernized dependency management and fixed OpenSSH key support - Migrated from deprecated dep to Go modules for better dependency management - Upgraded triton-go from v0.2.0 (2017) to v1.8.6 (2023) which includes modern OpenSSH private key format support - Updated authentication API calls to use new PrivateKeySignerInput and SSHAgentSignerInput structures - Updated import paths from github.com/joyent to github.com/TritonDataCenter following repository migration - Replaced deprecated ioutil.ReadFile with os.ReadFile - Removed old vendor directory and dep configuration files (Gopkg.toml, Gopkg.lock) This resolves SSH connection failures when users have modern OpenSSH format keys (BEGIN OPENSSH PRIVATE KEY) that were unsupported by the previous triton-go version which only handled legacy RSA format keys (BEGIN RSA PRIVATE KEY).
…hen acting as another user
…from signers
The Username field in PrivateKeySignerInput and SSHAgentSignerInput was causing authentication failures ("InvalidCredentials: Invalid authorization credentials") when using "act as" functionality with admin accounts acting on behalf of target accounts in Rancher. Commenting out Username from signers and relying on ClientConfig.AccountName for "act as" functionality restores the working behavior from before the triton-go upgrade.
🤖 Generated with [Claude Code](https://claude.ai/code)
Ignore the docker-machine-driver-triton binary output to keep it out of version control. 🤖 Generated with [Claude Code](https://claude.ai/code)
Provides guidance to Claude Code instances working in this repository, including build commands, architecture overview, and key configuration patterns for the Docker Machine driver. 🤖 Generated with [Claude Code](https://claude.ai/code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in #13.