Performance improvements #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the performance of the isProfane method by returning true after any bad word is found, rather than matching all bad words in the string.
Improves performance of clean by replacing use of:
`e.replaceAll(RegExp('.'), '*')`
with:
`''.padLeft(e.length, '*')`
I benchmarked a few different methods before settling on this implementation:
1. `padLeft`, i.e. `''.padLeft(e.length, '*')`
2. Dart's built-in string multiplication, i.e. `'*' * e.length`
3. The existing implementation
For the benchmark I replaced a string with 10,000,000 characters. The results were conclusive:
```
$ dart bad_words/benchmark/filter_benchmark.dart
PadLeft(RunTime): 131323.25 us.
StrMultiply(RunTime): 306138.85714285716 us.
RegExp(RunTime): 7393837.0 us.
```
The `padLeft` method performed around 56x faster than the previous implementation.
Improve performance by using a set literal rather than list literal for the bad words. Making this change also required removal of some duplicate values.
Owner
|
@benbarbersmith sorry for the MIA. I really like these improvements, and I'm inclined to absolutely merge. |
Contributor
Author
|
Several of the words in the list were repeated. (Once I converted the list to a set literal, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bundle of a few minor performance improvements:
isProfanemethod by returning true after any bad word is found, rather than matching all bad words in the string.cleanby 56x by replacing use ofe.replaceAll(RegExp('.'), '*')with''.padLeft(e.length, '*').See commit messages for more detail.