Skip to content

Persist light theme on refresh #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Persist light theme on refresh #513

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a951c27
Fixes #414.
samcunliffe Feb 2, 2025
76f9f0f
Merge remote-tracking branch 'origin/main' into fix-light-dark-toggle…
samcunliffe Feb 3, 2025
29f0d9a
Really the comment?
samcunliffe Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion docs/_includes/header_custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,24 @@

<script>
const toggleDarkMode = document.querySelector(".js-toggle-dark-mode");

jtd.addEvent(toggleDarkMode, "click", function () {
if (jtd.getTheme() === "light") {
jtd.setTheme("dark");
toggleDarkMode.textContent = "☼";
localStorage.setItem("theme", "dark");
} else {
jtd.setTheme("light");
toggleDarkMode.textContent = "☾";
localStorage.setItem("theme", "light");
}
});

// TODO: we can probably delete this (hacky workaround) if/when just-the-docs/#1223 is fixed.
// Meanwhile, we check each time if there is a theme written to local storage and obey it.
window.addEventListener("DOMContentLoaded", function () {
if (localStorage.getItem("theme") === "dark") {
jtd.setTheme("dark");
toggleDarkMode.textContent = "☼";
} else {
jtd.setTheme("light");
toggleDarkMode.textContent = "☾";
Expand Down