Skip to content

Add label to theme-switcher button. #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

Add label to theme-switcher button. #543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ef2b9
Fixes #537 adding aria label to textless button.
samcunliffe Jun 3, 2025
59d5d31
Revert Gemfile changes... should be handled by Renovate.
samcunliffe Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions docs/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ GEM
http_parser.rb (~> 0)
eventmachine (1.2.7)
ffi (1.17.2)
ffi (1.17.2-aarch64-linux-gnu)
ffi (1.17.2-aarch64-linux)
ffi (1.17.2-aarch64-linux-musl)
ffi (1.17.2-arm-linux-gnu)
ffi (1.17.2-arm-linux)
ffi (1.17.2-arm-linux-musl)
ffi (1.17.2-arm64-darwin)
ffi (1.17.2-x86-linux-gnu)
ffi (1.17.2-x86-linux)
ffi (1.17.2-x86-linux-musl)
ffi (1.17.2-x86_64-darwin)
ffi (1.17.2-x86_64-linux-gnu)
ffi (1.17.2-x86_64-linux)
ffi (1.17.2-x86_64-linux-musl)
forwardable-extended (2.6.0)
google-protobuf (4.30.2)
Expand Down Expand Up @@ -100,33 +100,33 @@ GEM
sass-embedded (1.87.0)
google-protobuf (~> 4.30)
rake (>= 13)
sass-embedded (1.87.0-aarch64-linux-android)
sass-embedded (1.87.0-aarch64-linux)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-aarch64-linux-gnu)
sass-embedded (1.87.0-aarch64-linux-android)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-aarch64-linux-musl)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-aarch64-mingw-ucrt)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-arm-linux-androideabi)
sass-embedded (1.87.0-arm-linux)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-arm-linux-gnueabihf)
sass-embedded (1.87.0-arm-linux-androideabi)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-arm-linux-musleabihf)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-arm64-darwin)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-riscv64-linux-android)
sass-embedded (1.87.0-riscv64-linux)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-riscv64-linux-gnu)
sass-embedded (1.87.0-riscv64-linux-android)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-riscv64-linux-musl)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-x86_64-darwin)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-x86_64-linux-android)
sass-embedded (1.87.0-x86_64-linux)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-x86_64-linux-gnu)
sass-embedded (1.87.0-x86_64-linux-android)
google-protobuf (~> 4.30)
sass-embedded (1.87.0-x86_64-linux-musl)
google-protobuf (~> 4.30)
Expand All @@ -136,32 +136,32 @@ GEM
webrick (1.9.1)

PLATFORMS
aarch64-linux
aarch64-linux
aarch64-linux-android
aarch64-linux-gnu
aarch64-linux-musl
aarch64-mingw-ucrt
arm-linux
arm-linux
arm-linux-androideabi
arm-linux-gnu
arm-linux-gnueabihf
arm-linux-musl
arm-linux-musleabihf
arm64-darwin
riscv64-linux
riscv64-linux-android
riscv64-linux-gnu
riscv64-linux-musl
ruby
x86-cygwin
x86-linux
x86-linux
x86-linux-android
x86-linux-gnu
x86-linux-musl
x86-mingw-ucrt
x86_64-cygwin
x86_64-darwin
x86_64-linux
x86_64-linux
x86_64-linux-android
x86_64-linux-gnu
x86_64-linux-musl

DEPENDENCIES
Expand Down
6 changes: 5 additions & 1 deletion docs/_includes/header_custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
<button class="btn js-toggle-dark-mode">☼</button>
<button class="btn js-toggle-dark-mode" aria-label="Switch to light mode">
☼
</button>

<script>
const toggleDarkMode = document.querySelector(".js-toggle-dark-mode");
jtd.addEvent(toggleDarkMode, "click", function () {
if (jtd.getTheme() === "light") {
jtd.setTheme("dark");
toggleDarkMode.textContent = "☼";
toggleDarkMode.ariaLabel = "Switch to light mode";
localStorage.setItem("theme", "dark");
} else {
jtd.setTheme("light");
toggleDarkMode.textContent = "☾";
toggleDarkMode.ariaLabel = "Switch to dark mode";
localStorage.setItem("theme", "light");
}
});
Expand Down
Loading