DRY up the test code a bit. #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tmp_path fixture from every test, but then need to write a nested function for the fixture. Also add a DEFAULT_CONFIG for the cookiecutter generation.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matt-graham
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
This looks great to me - even if it doesn't reduce line count significantly, I think the avoidance of having the same setup code across multiple tests makes the tests much more readable. I've added a couple of small suggestions and a question about how we're managing imports from helpers.py module, but these are all minor and from my perpsective this looks good to merge irrespective!
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
for more information, see https://pre-commit.ci
Also add a default_config_with fixture for default plus one change (the main use case in our parametrised tests).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
paddyroddy
reviewed
Jul 23, 2025
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
for more information, see https://pre-commit.ci
matt-graham
reviewed
Jul 23, 2025
matt-graham
reviewed
Jul 23, 2025
matt-graham
reviewed
Jul 23, 2025
matt-graham
reviewed
Jul 23, 2025
p-j-smith
requested changes
Jul 23, 2025
…to be used at once. Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Contravenes PT003 but "Explicit is better than implicit." Co-authored-by: Paddy Roddy <patrickjamesroddy@gmail.com>
samcunliffe
force-pushed
the
sc/dry-up-test-fixtures
branch
from
4816a6f to
571679c
Compare
|
In the end, I think I prefer Matt's way. Though the implicit parameterisation does look very useful. |
p-j-smith
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmp_pathfixture from every test...default_configanddefault_config_withfixtures to help the cookiecutter generation.In the end it doesn't actually reduce the linecount (because I had to add to the docstrings).