feat(ui5-icon): implement accessibilityInfo getter #12604
Conversation
|
🚀 Deployed on https://pr-12604--ui5-webcomponents-preview.netlify.app |
…d only for decorative mode
|
|
||
| get accessibilityInfo() { | ||
| if (this.mode === IconMode.Decorative) { | ||
| return undefined; |
There was a problem hiding this comment.
Hello @IlianaB
although the code is completely fine, we would like to suggest a small change - returning empty object {}, instead of undefined when the Icon is decorative.
Context
There was one thing we did not think of until now and it's that the base class (UI5Element) returns undefined by default. And, when decorative, the Icon also returns undefined.
In this case, the component that reads the accessibilityInfo of the components it contains, can't determine if the child component does not implement accessibilityInfo at all or the child component implements it, but must remain hidden from a11y point of view (as the decorative Icon).
For example, the Table has logic by design to provide default accessibility for elements that don't provide such. And in this case, it can't determine if it should provide such default accessibility or not. It reads the accessibilityInfo from the Icon, gets undefined, and applies default accessibility logic (but should not as it's decorative icon and should be hidden from a11y point of view).
We had to decide between these 3 options and picked up the first:
- returning {}
- returning null
- or removing the base implementation
related to #7729