-
Notifications
You must be signed in to change notification settings - Fork 279
fix(ui5-popover): render block layers in the correct order #12659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kskondov
wants to merge
20
commits into
main
Choose a base branch
from
ui5-popover-block-layers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+380
−58
Open
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e76d000
fix(ui5-popover): render block layers in the correct order
kskondov 9f880ec
fix(ui5-popover): render block layers in the correct order
kskondov 2f34f5c
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 598adbb
chore: handle opening and closing
TeodorTaushanov f7fd078
fix(ui5-popover): render block layers in the correct order
kskondov 9b7f595
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 63fe5d3
chore: improve TypeScript structure
TeodorTaushanov b214070
chore: improve TypeScript structure, fix some issues
TeodorTaushanov da23cdf
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 4a25afd
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov b4ea772
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov d2d83e6
chore: improve code
TeodorTaushanov 2a94f75
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 06049d7
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov dc01f29
chore: address code comments
TeodorTaushanov c0a5936
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 75cc691
chore: address code comments
TeodorTaushanov b6ae187
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov 1204bbe
chore: fix tests
TeodorTaushanov ff2da1c
Merge remote-tracking branch 'origin/main' into ui5-popover-block-layers
TeodorTaushanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,9 @@ | |
| border: none; | ||
| overflow: visible; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .sapUiBLy[popover] { | ||
| width: 100%; | ||
| height: 100%; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in getTopmostPopup - AllOpenedPopupsRegistry.openedRegistry potentially could be empty and then the code will fail with error. Add a check and return null if empty