feat(framework): introduce loadBaseThemingCSSVariables configuration #12699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
changed the title
Collaborator
|
🚀 Deployed on https://pr-12699--ui5-webcomponents-preview.netlify.app |
vladitasev
reviewed
Nov 24, 2025
| formatSettings: FormatSettings, | ||
| fetchDefaultLanguage: boolean, | ||
| defaultFontLoading: boolean, | ||
| defaultCSSVariablesLoading: boolean, |
Contributor
There was a problem hiding this comment.
Maybe loadThemingCSSVariables would be more fitting as the previous entry (defaultFontLoading) refers to the default font, but for CSS variables maybe default is not the right term
Contributor
Author
There was a problem hiding this comment.
Renamed it to loadBaseThemingCSSVariables. Is it a good idea the name to include base since the variables are coming from theming-base-content package?
nnaydenow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
loadBaseThemingCSSVariablesconfiguration setting, allowing applications to control whether the CSS variables from the@sap-theming/theming-base-contentpackage should be loaded.Part of: #12491