docs(ui5-table): adding acc test page #12708
Conversation
The test page includes features and configuration options that need to be tested for accessibility
|
|
|
|
aborjinik
left a comment
aborjinik
left a comment
There was a problem hiding this comment.
Thanks Oliver this will help a lot!
|
|
||
| <ui5-table id="productsTable" accessible-name-ref="tableTitle" overflow-mode="Popin" row-action-count="2"> | ||
| <ui5-table-selection-multi id="selection" slot="features"></ui5-table-selection-multi> | ||
| <ui5-table-growing id="growing" type="Scroll" slot="features"></ui5-table-growing> |
There was a problem hiding this comment.
Can you please add a switch for Scroll and Button, BTW I guess the property called mode not type.
It is not implemented in WC fully but there is a difference for the total count when Scroll or Button mode is used in the m/Table
There was a problem hiding this comment.
I added a select to change the growing mode, but it doesn't seem to have any effect. Same in the TableGrowing example.
There was a problem hiding this comment.
Something like below should work. As mentioned the property called mode not type.
https://ui5.github.io/webcomponents/nightly/components/TableGrowing/#growing-with-scrolling
There was a problem hiding this comment.
Initially the scrolling works. When I switch to button, the More button is shown and the load-more event is fired on press. But, when I switch to scroll again, the event is not fired anymore.
There was a problem hiding this comment.
I tried creating the growing again, but didn't change anything
| <ui5-table-cell><ui5-label><b>Wireless Charger Pad</b><br><a href="#" aria-label="Product ID WC-4409">WC-4409</a></ui5-label></ui5-table-cell> | ||
| <ui5-table-cell><ui5-label>ChargeIt</ui5-label></ui5-table-cell> | ||
| <ui5-table-cell><ui5-label>Accessories</ui5-label></ui5-table-cell> | ||
| <ui5-table-cell><ui5-label style="color: #2b7c2b" role="status" aria-label="In Stock"><b>In Stock</b></ui5-label></ui5-table-cell> |
There was a problem hiding this comment.
We will get a ticket "The meaning of the color must be announced" :)
Please seriously consider this maybe a Tag could be an option https://ui5.github.io/webcomponents/components/Tag/#designs
There was a problem hiding this comment.
The AMP Tool reports non-sufficient contrast, so I decided to just keep it as plain text for now
3 participants
The test page includes features and configuration options that need to be tested for accessibility.