Address potential leak and various code cleanup on pdftotext #168
+65
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD1938
reviewed
Dec 28, 2025
Member
AD1938
left a comment
AD1938
left a comment
There was a problem hiding this comment.
LGTM. This will need another team member to review and test before merging. @jerryzhou196
mikomikotaishi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
pdftotext.ccused non-standard features such as VLAs and repeatedmemcpy()calls. This pull request replaces the VLA andmemcpy()calls with direct string construction, and removes the no-op function, replacing it with a lambda. Also, becausepoppler::document::load_from_raw_data()returns a pointer, it makes sure to freedocby using a smart pointer and usesstd::call_once()onpoppler::set_debug_error_function()to prevent potential race condition if called by multiple goroutines.