Improve out arguments assignability, for both validation and expression compilation (STUD-76892) #376
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
2 times, most recently
from
a4e280f to
74d08ba
Compare
gpanaitescu
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
from
74d08ba to
cd9b0d8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
from
cd9b0d8 to
47a4613
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
from
47a4613 to
cf42473
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
3 times, most recently
from
aa33d51 to
a46c178
Compare
…on compilation (STUD-76892)
gpanaitescu
force-pushed
the
fix/validate_and_compile_safe_cast_arguments
branch
from
a46c178 to
5734aae
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| internal static string CreateValueCode(IEnumerable<string> types, string names, string code, string activityId, int index) | ||
| { | ||
| var serializedArgumentTypes = string.Join(CompilerHelper.Comma, types); | ||
| if (types.Count() <= 16) // .net defines Func<TResult>...Func<T1,...T16,TResult) |
There was a problem hiding this comment.
The comment has a typo in 'Funct' which should be 'Func'.
Copilot uses AI. Check for mistakes.
| /// <param name="variableName">The name of the variable to be cast. If null or whitespace, "null" is used instead.</param> | ||
| /// <param name="targetType">The target <see cref="Type"/> to which the variable is being cast.</param> | ||
| /// <returns>A string in the format "<paramref name="variableName"/> as <paramref name="targetType"/>" for valid types, otherwise just the variable name.</returns> |
There was a problem hiding this comment.
The XML documentation uses <paramref> tags in the returns description, but these should be <paramref name=\"variableName\"/> and <paramref name=\"targetType\"/> to properly reference the parameters.
Copilot uses AI. Check for mistakes.
3 participants
https://uipath.atlassian.net/browse/STUD-76892