feat: refactored ContextGroundingVectorStore to improve type safety #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
from
ced5c6f to
189c162
Compare
radu-mocanu
reviewed
Oct 28, 2025
src/uipath_langchain/vectorstores/context_grounding_vectorstore.py
Outdated
Show resolved
Hide resolved
radu-mocanu
reviewed
Oct 28, 2025
src/uipath_langchain/vectorstores/context_grounding_vectorstore.py
Outdated
Show resolved
Hide resolved
radu-mocanu
reviewed
Oct 28, 2025
src/uipath_langchain/vectorstores/context_grounding_vectorstore.py
Outdated
Show resolved
Hide resolved
radu-mocanu
reviewed
Oct 28, 2025
| execution_context = ExecutionContext() | ||
|
|
||
| # Create a temporary UiPath SDK instance to get the required services | ||
| sdk = UiPath(base_url=self.uipath_url, secret=access_token) |
Collaborator
There was a problem hiding this comment.
can t we just initialize UiPath() with the desired base_url and secret and then pass it to the ContextGroundingVectorStore ctor?
why is all this refactor needed?
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
5 times, most recently
from
a7fc34b to
6ab1882
Compare
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
2 times, most recently
from
f3d168d to
365c57e
Compare
radu-mocanu
reviewed
Oct 28, 2025
| uipath_sdk: Optional UiPath SDK instance. | ||
| folder_path: Optional folder path for folder-scoped operations | ||
| """ | ||
| self.index_name = index_name |
radu-mocanu
reviewed
Oct 28, 2025
| folder_path: Optional folder path for folder-scoped operations | ||
| """ | ||
| self.index_name = index_name | ||
| self.folder_path = folder_path |
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
4 times, most recently
from
b79e226 to
3ea9bf4
Compare
radu-mocanu
approved these changes
Oct 29, 2025
radu-mocanu
requested changes
Oct 29, 2025
Collaborator
radu-mocanu
left a comment
radu-mocanu
left a comment
There was a problem hiding this comment.
add a short PR description with the changes made please
adrian-badea
changed the title
adrian-badea
changed the title
adrian-badea
changed the title
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
from
3ea9bf4 to
34e1ed2
Compare
radu-mocanu
approved these changes
Oct 29, 2025
Collaborator
|
commit message should follow conventional commit structure |
adrian-badea
changed the title
adrian-badea
force-pushed
the
feature/update_context_grounding_vectorstore
branch
from
34e1ed2 to
95e0385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the ContextGroundingVectorStore implementation to improve type safety, structure, and maintainability while keeping functional parity with the previous version.
⸻
Key Changes
Refactored class for clarity and modern typing
• Added precise type annotations using | unions and Self return types.
• Replaced Optional[...] with more concise modern Python 3.10+ syntax.
• Added @OverRide decorators for all methods implementing the VectorStore interface.
🧩 Introduced _convert_results_to_documents() helper
• Centralized logic for converting ContextGroundingQueryResponse objects to Document instances.
• Improved metadata safety (handles missing or None fields gracefully).
🔐 Reinforced read-only behavior
• add_texts(), delete(), and from_texts() explicitly raise NotImplementedError with clearer messages.