Skip to content

Fix dropdown interaction #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix dropdown interaction #1088

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
668a3d2
FIX: Fixed interaction with dropdown UI
Mar 12, 2020
66c42ff
Added additional check to determine canvas sorting order of hit objec…
Mar 12, 2020
325ec66
Merge branch 'develop' into fix-dropdown-interaction
ekcoh Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,19 +397,42 @@ private RaycastResult PerformRaycast(ExtendedPointerEventData eventData)
// the first shot.
if (eventData.pointerType == UIPointerType.Tracked && TrackedDeviceRaycaster.s_Instances.length > 0)
{
//Store the closest result
RaycastResult raycastResult = default;
//Store the closest graphic's distance
float distance = float.MaxValue;
//The current TrackedDeviceRaycaster we are looking at
TrackedDeviceRaycaster trackedDeviceRaycaster;
//Owning canvas of the new comparison
Canvas raycastCanvas;
//Owning canvas of current result
Canvas raycastResultCanvas;
for (var i = 0; i < TrackedDeviceRaycaster.s_Instances.length; ++i)
{
var trackedDeviceRaycaster = TrackedDeviceRaycaster.s_Instances[i];
trackedDeviceRaycaster = TrackedDeviceRaycaster.s_Instances[i];
m_RaycastResultCache.Clear();
trackedDeviceRaycaster.PerformRaycast(eventData, m_RaycastResultCache);
if (m_RaycastResultCache.Count > 0)
{
var raycastResult = m_RaycastResultCache[0];
m_RaycastResultCache.Clear();
return raycastResult;
//Iterate through the list of result to determine the closest hit graphic
foreach (RaycastResult raycast in m_RaycastResultCache)
{
raycastCanvas = raycast.gameObject.GetComponentInParent<Canvas>();
raycastResultCanvas = raycastResult.gameObject?.GetComponentInParent<Canvas>();
//Update result if the the new raycast's owning canvas is of a higher sorting order OR if the sorting order is the same and the new raycast is closer
if (raycastResultCanvas == null || (raycastCanvas.sortingOrder > raycastResultCanvas.sortingOrder || (raycastCanvas.sortingOrder == raycastResultCanvas.sortingOrder && raycast.distance < distance)))
{
//Update the closest distance
distance = raycast.distance;
//Store the result
raycastResult = raycast;
}
}
}
}
return default;
m_RaycastResultCache.Clear();
//Return the closest result or default if none exist
return raycastResult;
}

// Otherwise pass it along to the normal raycasting logic.
Expand Down