Skip to content

Conversation

@BaalEvan
Copy link

@BaalEvan BaalEvan commented Oct 12, 2021

Description

PreviewGUI is missing in new Input System so i added toString Method based on PointerInputModule

Changes made

Added ToString override to InputSystemUIInputModule

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

@BaalEvan BaalEvan marked this pull request as draft October 12, 2021 22:59
@BaalEvan BaalEvan marked this pull request as ready for review October 12, 2021 22:59
@jfreire-unity jfreire-unity added the waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers label Mar 3, 2023
@ekcoh
Copy link
Collaborator

ekcoh commented Oct 21, 2025

If work is resumed on this PR it must be updated with latest changes from develop to not cause CI issues.

# Conflicts:
#	Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
@BaalEvan
Copy link
Author

There is no more work to be done; it's just a single method and a removed comment with ////TODO: ToString() method a la PointerInputModule waiting for review (or any feedback) for 4 years xD @ekcoh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants