Skip to content

P3te/ros2 nsecs fix #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

P3te/ros2 nsecs fix #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2ee7f2
Merge pull request #7 from Unity-Technologies/dev
P3TE May 17, 2022
ea539f4
Merge pull request #8 from Unity-Technologies/dev
P3TE Jun 7, 2023
27f2b29
Fixing infinite recursive call.
P3TE-QUT Jun 7, 2023
99d6a33
Updating CHANGELOG.md with TimeMsg nsecs bug fix.
P3TE-QUT Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.unity.robotics.ros-tcp-connector/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a

### Fixed

Fixing bug in ROS2 where the getter TimeMsg nsecs caused a StackOverflowException


## [0.7.0-preview] - 2022-02-01

Expand Down
2 changes: 1 addition & 1 deletion com.unity.robotics.ros-tcp-connector/Runtime/Messages/HandwrittenMessages/msg/TimeMsg.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public override string ToString()

// for convenience when writing ROS2 agnostic code
public uint secs { get => (uint)sec; set => sec = (int)value; }
public uint nsecs { get => nsecs; set => nsecs = value; }
public uint nsecs { get => nanosec; set => nanosec = value; }

public TimeMsg()
{
Expand Down