Skip to content

Conversation

urmahp
Copy link
Contributor

@urmahp urmahp commented May 16, 2025

No description provided.

@urmahp urmahp requested a review from a team May 16, 2025 06:29
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (torque_control@ebe30d2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/ur/ur_driver.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             torque_control     #323   +/-   ##
=================================================
  Coverage                  ?   75.96%           
=================================================
  Files                     ?       87           
  Lines                     ?     3757           
  Branches                  ?      416           
=================================================
  Hits                      ?     2854           
  Misses                    ?      686           
  Partials                  ?      217           
Flag Coverage Δ
start_ursim 81.03% <ø> (?)
ur20-latest 73.92% <72.22%> (?)
ur5-3.14.3 74.48% <72.22%> (?)
ur5e-10.7.0 68.64% <72.22%> (?)
ur5e-5.9.4 74.34% <72.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
}

bool UrDriver::setFrictionCompensation(const bool friction_compensation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be great to start testing the script command functions from the ur_driver object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is a good idea. But we should probably not start doing it on a beta branch, but start by adding the first test to the master branch, which would then test some of the other commands.

urmahp and others added 3 commits May 19, 2025 10:21
Co-authored-by: Felix Exner <feex@universal-robots.com>
Co-authored-by: Felix Exner <feex@universal-robots.com>
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urmahp urmahp requested a review from urfeex May 19, 2025 09:25
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my suggestion that looks fine.

@urfeex urfeex merged commit 7b01a7f into UniversalRobots:torque_control May 19, 2025
19 of 22 checks passed
@urmahp urmahp deleted the friction_compensation branch May 19, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants