-
Notifications
You must be signed in to change notification settings - Fork 128
Added command to set friction compensation for the torque command #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command to set friction compensation for the torque command #323
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## torque_control #323 +/- ##
=================================================
Coverage ? 75.96%
=================================================
Files ? 87
Lines ? 3757
Branches ? 416
=================================================
Hits ? 2854
Misses ? 686
Partials ? 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/ur/ur_driver.cpp
Outdated
} | ||
} | ||
|
||
bool UrDriver::setFrictionCompensation(const bool friction_compensation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be great to start testing the script command functions from the ur_driver object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is a good idea. But we should probably not start doing it on a beta branch, but start by adding the first test to the master branch, which would then test some of the other commands.
Co-authored-by: Felix Exner <feex@universal-robots.com>
Co-authored-by: Felix Exner <feex@universal-robots.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized: The documentation would also require an update for this: https://github.com/UniversalRobots/Universal_Robots_Client_Library/blob/master/doc/architecture/script_command_interface.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my suggestion that looks fine.
7b01a7f
into
UniversalRobots:torque_control
No description provided.