-
Notifications
You must be signed in to change notification settings - Fork 128
Added commands to set pd controller gains and maximum joint torques #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added commands to set pd controller gains and maximum joint torques #342
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## torque_control #342 +/- ##
=================================================
Coverage ? 81.73%
=================================================
Files ? 1
Lines ? 230
Branches ? 0
=================================================
Hits ? 188
Misses ? 42
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have minor documentation suggestions. Feel free to accept or ignore them.
client_->readMessage(command, message); | ||
|
||
// 8 is set PD controller gains | ||
int32_t expected_command = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could think about moving the enum to a public namespace so that can be reused here. or is there a specific reason why enum class ScriptCommand
is a private member of ScriptCommandInterface
?
That's probably not for this PR, however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think its because it is only intended to be used when sending commands to the external control script. But would make sense to make them available for the test cases. But yes should probably be done in separate PR.
Co-authored-by: Felix Exner <feex@universal-robots.com>
No description provided.