Skip to content

Conversation

urmahp
Copy link
Contributor

@urmahp urmahp commented Jun 5, 2025

No description provided.

@urmahp urmahp requested a review from a team June 5, 2025 07:06
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (torque_control@9cecbff). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             torque_control     #342   +/-   ##
=================================================
  Coverage                  ?   81.73%           
=================================================
  Files                     ?        1           
  Lines                     ?      230           
  Branches                  ?        0           
=================================================
  Hits                      ?      188           
  Misses                    ?       42           
  Partials                  ?        0           
Flag Coverage Δ
start_ursim 81.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have minor documentation suggestions. Feel free to accept or ignore them.

client_->readMessage(command, message);

// 8 is set PD controller gains
int32_t expected_command = 8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could think about moving the enum to a public namespace so that can be reused here. or is there a specific reason why enum class ScriptCommand is a private member of ScriptCommandInterface?

That's probably not for this PR, however.

Copy link
Contributor Author

@urmahp urmahp Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think its because it is only intended to be used when sending commands to the external control script. But would make sense to make them available for the test cases. But yes should probably be done in separate PR.

urmahp and others added 2 commits June 5, 2025 10:54
Co-authored-by: Felix Exner <feex@universal-robots.com>
@urmahp urmahp merged commit f45dda1 into UniversalRobots:torque_control Jun 5, 2025
7 of 22 checks passed
@urmahp urmahp deleted the configurable_pd_gains branch June 5, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants