Skip to content

Conversation

mathias31415
Copy link

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (289c747) to head (4dda6bd).

Files with missing lines Patch % Lines
src/ur/instruction_executor.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   78.10%   77.36%   -0.75%     
==========================================
  Files          92       92              
  Lines        4138     4135       -3     
  Branches      456      456              
==========================================
- Hits         3232     3199      -33     
- Misses        676      703      +27     
- Partials      230      233       +3     
Flag Coverage Δ
start_ursim 80.07% <ø> (-3.94%) ⬇️
ur20-latest 75.47% <0.00%> (-0.21%) ⬇️
ur5-3.14.3 75.97% <0.00%> (-0.26%) ⬇️
ur5e-10.7.0 70.75% <0.00%> (-0.20%) ⬇️
ur5e-5.9.4 75.98% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, a better approach might be to allow multiple callbacks registered in the driver. I'll make a PR for that.

@mathias31415
Copy link
Author

Closing as this is outdated due to PR #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants