-
Notifications
You must be signed in to change notification settings - Fork 128
Update RTDE list to include new fields #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 77.95% 77.56% -0.40%
==========================================
Files 92 92
Lines 4165 4163 -2
Branches 461 461
==========================================
- Hits 3247 3229 -18
- Misses 682 695 +13
- Partials 236 239 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also reordered the fields to match the documentation order.
7153780
to
9a12414
Compare
To which documentation did you do the reordering? It doesn't match https://docs.universal-robots.com/tutorials/communication-protocol-tutorials/rtde-guide.html#field-names-and-associated-types |
It does match that one, except for the fields which are both input and output, those have been grouped by them selves, because they would otherwise need to appear twice. So other than "input_yyyy_register_X" it should be the same. |
Could you please also update https://github.com/UniversalRobots/Universal_Robots_Client_Library/blob/9e5269319fac311e428d36d260f25678a546ec16/tests/resources/exhaustive_rtde_output_recipe.txt? And we should probably remove the |
Also reordered the fields to match the documentation order.