Skip to content

Crash fixes? #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Crash fixes? #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c2832
Attempt to fix a crash
hiimjasmine00 Apr 1, 2025
9290810
Wow
hiimjasmine00 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Makes the Epic, Legendary and Mythic fires animated!
# Credits
- Uproxide
- Brift
- hiimjustin00 (Pretty Much rewrote it lmbao)
- hiimjasmine00 (Pretty Much rewrote it lmbao)
- ShineUA (Clipping Node on Level Cell)
- Cooper (help with sprite animations)

2 changes: 1 addition & 1 deletion mod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"version": "v1.1.2",
"developers": [
"Uproxide",
"hiimjustin00",
"hiimjasmine00",
"Brift"
],
"description": "Makes the Epic, Legendary and Mythic fires animated!",
Expand Down
10 changes: 6 additions & 4 deletions src/hooks/LevelCell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ class $modify(MyLevelCell, LevelCell) {

if (!Loader::get()->isModLoaded("cdc.level_thumbnails")) return;

queueInMainThread([this, difficultyNode, difficultySpr, level] {
if (!getParent() || !typeinfo_cast<DailyLevelNode*>(getParent())) return;
auto hasCoins = level->m_coins > 0;
auto parent = getParent();
queueInMainThread([parent = Ref<CCNode>(parent), difficultyNode, difficultySpr, hasCoins] {
if (!typeinfo_cast<DailyLevelNode*>(parent.data())) return;

auto fireSprite = difficultyNode->getChildByID("animated-fire-sprite"_spr);
if (!fireSprite) {
Expand All @@ -40,15 +42,15 @@ class $modify(MyLevelCell, LevelCell) {
clippingNode->setPosition(fireSprite->getPosition());
clippingNode->setScale(fireSprite->getScale());

if (auto bgNode = static_cast<CCScale9Sprite*>(getParent()->getChildByID("background"))) {
if (auto bgNode = parent->getChildByID("background")) {
clippingNode->setStencil(CCLayerColor::create(
{0, 0, 0, 255},
fireSprite->getContentWidth(),
fireSprite->getContentHeight() / 2
+ bgNode->getContentHeight()
- difficultyNode->getPositionY()
- clippingNode->getPositionY()
- 6.0f - (level->m_coins > 0 ? 9.0f : 0.0f)
- 6.0f - (hasCoins > 0 ? 9.0f : 0.0f)
));
}

Expand Down