-
Notifications
You must be signed in to change notification settings - Fork 2
Detail L1 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Detail L1 #35
Conversation
started to split out sub-diagrams
no longer specify width, but fix it in the CSS so all diagrams use the same scale.
I think this is correct, since an observation is not *composed* of them, it is a concept that collects them. You can have an observation without anything.
|
Do we want to stick with calling the exposure time intervals "OnTime", or be more general, like TimeInterval or ExposureTime? Also where do the deadtime, etc go? Are they also in that object or separate? |
since plantuml 2025.02 now seems to put the connectors too close to the package boundaries for some reason
|
|
||
| OnTime | ||
| ------ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the OnTime (the previous GTIs), should we add as metadata the dead_time fraction? Or should we put this information (because I think that this is more a data than a metadata) as element of the interval (ie tstart, tstop, deadtime_fraction (optional))?
| } | ||
|
|
||
| Observation "1" -- "0..1" Pointing | ||
| ObsCore .r. Observation : "<<find>> >" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its position in the diagram is a bit weird... But it might be difficult to adjust.
| package VODF { | ||
| class Facility | ||
| class Instrument | ||
| Facility -- Instrument : <<has>> > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its position in the diagram is a bit weird... But it might be difficult to adjust.
|
|
||
| package VODF.L1 { | ||
|
|
||
| abstract class OnTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above my comment on the deadtime_fraction
bkhelifi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the improvements. I put here some comments
Uh oh!
There was an error while loading. Please reload this page.