refactor: extract interfaces for vTokens and Comptroller #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Aug 5, 2025
Exef
requested changes
Aug 6, 2025
| import { VToken } from "../../../Tokens/VTokens/VToken.sol"; | ||
| import { IVToken } from "../../../Tokens/VTokens/interfaces/IVToken.sol"; | ||
|
|
||
| interface IPolicyFacet { |
Contributor
There was a problem hiding this comment.
Missing natspec for all functions in the interface?
GitGuru7
reviewed
Aug 6, 2025
Contributor
GitGuru7
left a comment
GitGuru7
left a comment
There was a problem hiding this comment.
LGTM apart from the Natspec suggestions by Filip.
Debugger022
reviewed
Aug 6, 2025
Contributor
Debugger022
left a comment
Debugger022
left a comment
There was a problem hiding this comment.
interface VAIControllerInterface can be written as IVAIControllerInterface.
kkirka
force-pushed
the
refactor/interfaces
branch
from
4abb8f6 to
0b7a08a
Compare
kkirka
force-pushed
the
feat/solidity-0.8
branch
2 times, most recently
from
8f4dc66 to
a4c9e27
Compare
kkirka
force-pushed
the
refactor/interfaces
branch
2 times, most recently
from
fc42aa0 to
9274574
Compare
kkirka
force-pushed
the
refactor/interfaces
branch
from
9274574 to
e6e58b8
Compare
Exef
approved these changes
Aug 8, 2025
fred-venus
force-pushed
the
develop
branch
3 times, most recently
from
3c63d07 to
f2e5f93
Compare
fred-venus
force-pushed
the
develop
branch
3 times, most recently
from
f8786ac to
d1378e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors interfaces, most importantly vToken interfaces, to separate files to prevent cyclic references in future