Add Rails 8 support #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Morozzzko, thank you for looking into this! Appreciate the thoroughness here, you've absolutely done the right thing. I admittedly haven't come back to this in a little while (it sits at a high enough level of abstraction that hopefully that hasn't been a problem, but sorry for the delay anyhow!). I do wonder why Active Support is a necessary dependency for it – I'd hope it could work independently of the need for a particular version of Rails. I'll have a look tomorrow to refresh myself. |
|
Hey folks, any update here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to provide some Rails 8.0 support, as the gem is basically blocking from an update
I'd rather this gem not limit upper version of Rails, but that's probably not my call to make