Skip to content

Conversation

@Miran-Firdausi
Copy link

Changes I have made.

  • Created an endpoint validate-username which validates a given username.
  • It continues to work whether the api endpoints works or not, or the PAT is provided or not.
  • Fixed a minor bug which was causing a full page refresh on homescreen on form submit.

@vercel
Copy link

vercel bot commented Oct 24, 2025

@Miran-Firdausi is attempting to deploy a commit to the vishwagauravin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Miran-Firdausi
Copy link
Author

Please review the changes. If you are okay with the changes please provide the hacktoberfest-accepted label.

@VishwaGauravIn VishwaGauravIn changed the base branch from main to beta October 25, 2025 13:51
@VishwaGauravIn
Copy link
Owner

Why are you creating new API and then hitting the GitHub's API, also please try adding Timeout handling via controller in API.

@Miran-Firdausi
Copy link
Author

Miran-Firdausi commented Oct 25, 2025

Why are you creating new API and then hitting the GitHub's API

Using Next APIs ensures secrets are not exposed as they are run server side. So if we have to use PAT, it remains safe.

please try adding Timeout handling via controller in API.

I have added the timeout, please review.

@VishwaGauravIn
Copy link
Owner

We are not using any secret for GitHub API, kindly remove it and make a single hook for checking valid username.

@Miran-Firdausi
Copy link
Author

My suggestion would have to use the PAT, It increases the rate limit from 60 to 5000, but I have removed the logic as per your wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants