Skip to content

VIDSOL-345: Updated catalog info file #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
+21 −8
Merged

VIDSOL-345: Updated catalog info file #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions .vonage/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,26 @@
---
apiVersion: backstage.io/v1alpha1
kind: Component
kind: System
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'kind: System' definition with 'type: library' at line 11 is inconsistent. Systems typically contain multiple components rather than being libraries themselves. Consider using 'kind: Component' if this represents a single library.

Copilot uses AI. Check for mistakes.
Copy link

@odivorra odivorra Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mola...

Copy link
Contributor Author

@VZaphod VZaphod Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ we follow copilot recommendation or we keep with System?

Copy link

@odivorra odivorra Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the template ... you can assess.
Obviously, component cannot be in the first line. That must be system.
Component is the one in the second part, down below.
(Use english @VZaphod )

metadata:
name: vonage-video-react-app
name: video-react-ref-app # SERVICE NAME field
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'SERVICE NAME field' is misleading since this is defined as a System of type 'library' (line 11), not a service. Update the comment to accurately reflect the entity type.

Suggested change
name: video-react-ref-app # SERVICE NAME field
name: video-react-ref-app # SYSTEM NAME field

Copilot uses AI. Check for mistakes.
title: Video React Ref App # Title (human-friendly library name) field
description: Vonage Video API JS React reference application
annotations:
github.com/project-slug: vonage/vonage-video-react-app
backstage.io/techdocs-ref: dir:../docs/
vonage.com/jira-id: VPF # video general projects
spec:
type: library
owner: group:orgdata/vdk # helm "owner" orgdata squad id or general orgdata/vid
domain: video-api # Product this library belongs to
---
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
name: video-react-ref-app
description: Video React Ref App Component
annotations:
github.com/project-slug: Vonage/vonage-video-react-app # GH repo
spec:
type: service
lifecycle: production
owner: vonage-technology/video-client-team
domain: video
type: library
owner: group:orgdata/vdk
system: video-react-ref-app
lifecycle: production
Loading