Revert "Remove --print-symbol-map / --symbolmap (#7862)" #7895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit beda737.
tlively
approved these changes
Sep 11, 2025
|
Which one to they use? Can we at least remove the second alias? Can then move to another tool? What exactly it used for? |
|
Looks like it is used for similar reasons as emscripten did: to symbolize stack traces. They use the second alias directly. I think that's a reasonable use. They use wasm-opt to optimize, and this is a convenient way to get names for stack traces, without adding any new tools. |
|
Sorry, which alias to they use? Can we at least remove the |
|
They use the second name Yes, that comment is removable, I opened #7896 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit beda737.
This is used by j2cl.