[wasm-split] Escape names in manifest files #7898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions in languages like C++ have unallowed characters such as parentheses or whitespaces within their names, so if we put them in the manifest files they will not be matched with escaped names we use within Binaryen. This _escapes_ function names when we read them from manifest files.
tlively
approved these changes
Sep 12, 2025
src/tools/wasm-split/wasm-split.cpp
Outdated
| newSection = true; | ||
| continue; | ||
| } | ||
| Name func = WasmBinaryReader::escape(line); |
There was a problem hiding this comment.
Maybe call this escaped or name so we don't end up with a module name in a variable called func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in languages like C++ have unallowed characters such as parentheses or whitespaces within their names, so if we put them in the manifest files they will not be matched with escaped names we use within Binaryen. This escapes function names when we read them from manifest files.