[Custom Descriptors] Fix GTO after #7937 #7938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not leave unreachable ref.cast_desc instructions with descriptors arguments that have been optimized to no longer be descriptors. This was intended to be inluded in #7937.
kripken
approved these changes
Oct 1, 2025
| if (curr->type == Type::unreachable && curr->desc && | ||
| curr->desc->type != Type::unreachable) { | ||
| assert(curr->ref->type == Type::unreachable); | ||
| replaceCurrent(curr->ref); |
There was a problem hiding this comment.
Don't we need to drop the desc for any effects it might have?
There was a problem hiding this comment.
No, because the preceding ref operand is unreachable. The desc operand will never be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not leave unreachable ref.cast_desc instructions with descriptors
arguments that have been optimized to no longer be descriptors. This was
intended to be inluded in #7937.