SimplifyGlobals: Fix folding of exports #7940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(found by fuzzing wasm-split: the globals were exported and read from a second module, that then noticed the bug) |
tlively
approved these changes
Oct 2, 2025
| (global $B (ref $struct) (global.get $A)) | ||
|
|
||
| ;; CHECK: (export "A" (global $A)) | ||
| (export "A" (global $A)) |
There was a problem hiding this comment.
We could still optimize by exporting $B instead. Maybe worth considering as a follow-up?
There was a problem hiding this comment.
Added a TODO, that might be possible, not sure offhand about corner cases though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exported global can have extra uses, which prevent folding its value
into others.