wasi:filesystem@0.3.0-rc-2025-09-16: Add tests for symbolic links #139
Conversation
wingo
changed the title
wingo
force-pushed
the
filesystem-symbolic-links
branch
2 times, most recently
from
667abf4 to
b3e1496
Compare
wingo
changed the title
wingo
force-pushed
the
filesystem-symbolic-links
branch
from
b3e1496 to
8285239
Compare
|
Would it make sense to add this test case? WASIT found this sandbox escape in WAMR. In short, this tests that backslashes are properly handled in symlinks. |
|
|
||
| assert_eq!(ln_s("whatever", "").await, Err(ErrorCode::NoEntry)); | ||
| assert_eq!(ln_s("", "whatever").await, Err(ErrorCode::NoEntry)); | ||
| // symlink-at: async func(old-path: string, new-path: string) -> result<_, error-code>; |
There was a problem hiding this comment.
Did this belong up at line 68?
wingo
force-pushed
the
filesystem-symbolic-links
branch
from
8285239 to
8771068
Compare
wingo
force-pushed
the
filesystem-symbolic-links
branch
from
8771068 to
869e215
Compare
| ErrorCode::Loop | ||
| ); | ||
|
|
||
| ln_s("parent", "parent-link").await.unwrap(); |
There was a problem hiding this comment.
Windows Wasmtime failure:
Test filesystem-symbolic-links failed
[exit_code] 0 == 3
STDOUT:
STDERR:
thread '' (1) panicked at src/bin/filesystem-symbolic-links.rs:69:41:
called Result::unwrap() on an Err value: ErrorCode { code: 30, name: "not-permitted", message: "Operation not permitted, similar to EPERM in POSIX." }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: failed to run main module tests\rust\testsuite\wasm32-wasip3\filesystem-symbolic-links.wasm
| rm("self").await.unwrap(); | ||
|
|
||
| assert_eq!(ln_s("whatever", "").await, Err(ErrorCode::NoEntry)); | ||
| assert_eq!(ln_s("", "whatever").await, Err(ErrorCode::NoEntry)); |
There was a problem hiding this comment.
Wasmtime MacOS failure:
Test filesystem-symbolic-links failed
[exit_code] 0 == 134
STDOUT:
STDERR:
thread '' (1) panicked at src/bin/filesystem-symbolic-links.rs:92:5:
assertion left == right failed
left: Ok(())
right: Err(ErrorCode { code: 19, name: "no-entry", message: "No such file or directory, similar to ENOENT in POSIX." })
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: failed to run main module tests/rust/testsuite/wasm32-wasip3/filesystem-symbolic-links.wasm
3 participants
No description provided.