Skip to content

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Apr 11, 2024

As mentioned by Phil in #248, it does not make much sense right now to keep running tests against old versions of keria.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (72826cf) to head (3e50289).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #249      +/-   ##
===============================================
+ Coverage        82.75%   82.83%   +0.07%     
===============================================
  Files               46       46              
  Lines             4234     4194      -40     
  Branches          1029     1021       -8     
===============================================
- Hits              3504     3474      -30     
+ Misses             725      715      -10     
  Partials             5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan mentioned this pull request Apr 11, 2024
@rodolfomiranda
Copy link
Contributor

Agree, but now PR #241 needs 0.2.0-dev0.
Can you add it?

@lenkan
Copy link
Collaborator Author

lenkan commented Apr 12, 2024

Agree, but now PR #241 needs 0.2.0-dev0. Can you add it?

Hm. I think that will make the tests break on this PR because of the smids. I think you should add it to your PR as that is the one that adds support for 0.2.0-dev0.

@lenkan lenkan merged commit 42d3b14 into WebOfTrust:development Apr 12, 2024
@lenkan lenkan deleted the update-matrix branch April 12, 2024 07:42
daviddm pushed a commit to daviddm/signify-ts that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants