Skip to content

Conversation

Sotatek-Patrick-Vu
Copy link

  • In KERIA's credentialing.py endpoints: we started programmatically generating the OpenAPI docs from dataclasses so they are more likely to be maintained and get the added type hints.
  • In this PR, we automatically generated credential types from KERIA OpenAPI spec
  • This is a first pass - some complex types need more work to be more specific, such as JSON schemas.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition!

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (d48adc0) to head (79b336f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files           1        1           
  Lines         324      324           
  Branches       24       24           
=======================================
  Hits          316      316           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion on how to avoid the child processes and string matching in the type generation script. Please take a look.

Also, I think we should add linting to "scripts" directory. It's as easy as:

npm i --save-dev globals

Then add

    {
        files: ['scripts/**/*.js'],
        languageOptions: {
            globals: globals['node'],
        },
    }

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I added a suggestion for the eslint rules. The new changes allows for node.js globals to be used in the library, which we should not allow to ensure that the library can be used in a browser environment.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure whether you want to merge WebOfTrust/keria#373 first, then update the types here?

@iFergal
Copy link
Collaborator

iFergal commented Sep 19, 2025

Thanks @lenkan! I think it's probably best to merge KERIA first yeah, so we can leave this here.

Ideally we should do dev tags and update the KERIA in the compose too, though there are a few more PRs to come so maybe it's enough to do it at the very end of all of the PRs.

@kentbull
Copy link
Collaborator

kentbull commented Oct 9, 2025

@Sotatek-Patrick-Vu and @iFergal now that the KERIA PR has been merged let's get this one ready. I want to approve it as soon as possible and get a new release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants