Correct typos and improve error handling

[alex-x-x-x-x]

This PR fixes typos and adds comprehensive error handling to shell scripts to prevent silent failures and improve maintainability.

Error Handling in set_public_ip_and_start.sh

Before (silent failure risk):

# Setup a new, on-the-fly certificate for the HTTPS port
pushd /home/haproxy/certs
/usr/local/bin/generate-certs.sh
mv proxy.whatsapp.net.pem /etc/haproxy/ssl/proxy.whatsapp.net.pem
chown haproxy:haproxy /etc/haproxy/ssl/proxy.whatsapp.net.pem
popd

# Start HAProxy
haproxy -f "$CONFIG_FILE"

After (with error handling):

# Setup a new, on-the-fly certificate for the HTTPS port
pushd /home/haproxy/certs || {
    echo "[PROXYHOST] ERROR: Failed to change to /home/haproxy/certs directory" >&2
    exit 1
}
/usr/local/bin/generate-certs.sh || {
    echo "[PROXYHOST] ERROR: Certificate generation failed" >&2
    popd
    exit 1
}
mv proxy.whatsapp.net.pem /etc/haproxy/ssl/proxy.whatsapp.net.pem || {
    echo "[PROXYHOST] ERROR: Failed to move certificate to /etc/haproxy/ssl/" >&2
    popd
    exit 1
}
chown haproxy:haproxy /etc/haproxy/ssl/proxy.whatsapp.net.pem || {
    echo "[PROXYHOST] ERROR: Failed to set certificate ownership" >&2
    popd
    exit 1
}
popd

# Start HAProxy
haproxy -f "$CONFIG_FILE" || {
    echo "[PROXYHOST] ERROR: HAProxy failed to start" >&2
    exit 1
}

Error Handling in generate-certs.sh

Before (missing error check):

if [[ -e ./${CA_KEY} ]]; then
    echo "====> Using existing CA Key ${CA_KEY}"
else
    echo "====> Generating new CA key ${CA_KEY}"
    openssl genrsa -out ${CA_KEY} 4096
fi

After (with error check):

if [[ -e ./${CA_KEY} ]]; then
    echo "====> Using existing CA Key ${CA_KEY}"
else
    echo "====> Generating new CA key ${CA_KEY}"
    openssl genrsa -out ${CA_KEY} 4096 || exit 1
fi

Exit Code Fix in healthcheck.sh

Before (non-standard exit code):

if [ "$RESULT" != "" ]
then
  echo "[HEALTHCHECKER] Container failed healthchecks, L4 healthcheck on *.whatsapp.net failed"
  echo "[HEALTKCHECKER] Result $RESULT"
  exit -1;
fi

After (standard exit code + typo fix):

if [ "$RESULT" != "" ]
then
  echo "[HEALTHCHECKER] Container failed healthchecks, L4 healthcheck on *.whatsapp.net failed"
  echo "[HEALTHCHECKER] Result $RESULT"
  exit 1
fi

[meta-cla]

Hi @alex-x-x-x-x!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!