Skip to content

Conversation

brettviren
Copy link
Member

Small update to PR #199

It is mostly cleaning up and extending some tests and logging in the C++.

Some of the tests require WireCell/wire-cell-python#16

@brettviren brettviren requested a review from HaiwangYu April 21, 2023 20:35
@HaiwangYu
Copy link
Member

Thanks @brettviren for making this update. Noise simulation test results here:
https://www.phy.bnl.gov/~yuhw/wct-tests/pr-216/reports/0.24.1-110-g8249fe3c/history-comp1d/
Seems good to me. Let's merge it.

@HaiwangYu HaiwangYu merged commit 095eace into master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants