Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 24, 2025

Description

The minimum version should be three versions behind the latest WP release, so what with 6.9.0 slated for release on Dec 2nd, it should now become 6.6.

Includes updating the tests to match.

Suggested changelog entry

Changed

Related issues/external references

Previous: #2121, #2321. #2436, #2553

The minimum version should be three versions behind the latest WP release, so what with 6.9.0 slated for release on Dec 2nd, it should now become 6.6.

Includes updating the tests to match.

Previous: 2121, 2321. 2436, 2553
Copy link
Collaborator

@rodrigoprimo rodrigoprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The only question that I have is if this PR should also update phpcs.xml.dist.simple to bump the value of the minimum_wp_version property to 6.6 and testVersion to 7.2- (as WP 6.6 dropped support for PHP 7.0 and 7.1)? Or is the plan to address this separately?

@jrfnl
Copy link
Member Author

jrfnl commented Nov 24, 2025

The only question that I have is if this PR should also update phpcs.xml.dist.simple to bump the value of the minimum_wp_version property to 6.6 and testVersion to 7.2- (as WP 6.6 dropped support for PHP 7.0 and 7.1)? Or is the plan to address this separately?

@rodrigoprimo This setting vs the example file are two different decision points:

  • The setting is about accuracy for scanning.
  • The example file is just that: an example.

Updating those could potentially be combined in one PR, but updating the setting is something which MUST be done regularly for accurate scan results, while updating the example file has no consequences whatsoever and is something to do when someone thinks of it.

Also note that the example file was already updated recently via PR #2608 (first update in three years), so I don't have any plans to address this separately - or at all - in the foreseeable future.

If you believe the setting and the example file should be tightly coupled, I suggest you submit a PR to update the release checklist proposing that and sync the example file while you are at it. 🤷🏻‍♀️

@dingo-d dingo-d merged commit c2b30bf into develop Nov 25, 2025
48 of 49 checks passed
@dingo-d dingo-d deleted the feature/update-minimum-wp-version branch November 25, 2025 06:49
@rodrigoprimo
Copy link
Collaborator

If you believe the setting and the example file should be tightly coupled, I suggest you submit a PR to update the release checklist proposing that and sync the example file while you are at it. 🤷🏻‍♀️

I opened a PR with those changes: #2662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants