Fix: Localize repeated background images in Cover block (#794) #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Localize repeated background images in Cover block
Summary
Localizes images used as “repeated background” in
core/coverwhen “Localize images” is enabled. These images are copied into the theme’s assets and referenced via theme-relative URLs, removing dependency on the original uploads directory.Fixes
Changes
background-imageURL parsing to support quoted and unquotedurl(...).attrs.style.background.backgroundImage.url(Cover’s “Repeat background” attribute path).test_localize_cover_repeated_background_via_attrs()to verify attribute-defined repeated backgrounds localize to/assets/images/bg.pngand are replaced with a theme-relative URL.test_localize_cover_repeated_background_inline_style()to verify inlinebackground-image:url(...)repeated backgrounds localize to/assets/images/pattern.webp.Rationale
Repeated background images set via the Cover block’s attributes were missed, leaving absolute upload URLs. The media extractor now covers both inline CSS and attribute-defined backgrounds to align with “Localize images”.
Risk/Compatibility
/assets/images/) and parent/child theme URL handling.Testing
Checklist